[completer] Fix bug which causes integer divide by zero panicking when input buffer is empty #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
changed the title
| @@ -66,7 +66,7 @@ func (o *opCompleter) OnComplete() { | |||
| buf := o.op.buf | |||
| rs := buf.Runes() | |||
|
|
|||
| if o.IsInCompleteMode() && runes.Equal(rs, o.candidateSource) { | |||
| if o.IsInCompleteMode() && len(rs) > 0 && runes.Equal(rs, o.candidateSource) { | |||
There was a problem hiding this comment.
Use runes.Equal(rs, o.candidateSource) here is want to indicate whether user press twice <tab>.
o.candidateSource will be set to nil when o.ExitCompleteSelectMode() is called.
The problem is that runes.Equal([], nil) is still true.
So I suggests that change len(rs) > 0 to o.candidateSource != nil
|
Just to mention, the user who submit the commit is not a valid github user :) |
|
Updated the PR and, hopefully, fixed the user. Thanks for the heads up! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #53