Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release binaries on pull requests #2136

Merged
merged 2 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
on:
pull_request: {}
michi-covalent marked this conversation as resolved.
Show resolved Hide resolved
push:
# Sequence of patterns matched against refs/tags
tags:
- 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10

name: Create Release
name: Release

jobs:
build:
name: Create Release
name: Create Release ${{ github.event_name == 'pull_request' && '(dry-run)' }}
if: github.repository == 'cilium/cilium-cli'
runs-on: ubuntu-22.04
steps:
Expand All @@ -25,6 +26,7 @@ jobs:
run: make release

- name: Create Release
if: github.event_name == 'push'
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v0.1.15
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ local-release: clean
ARCHS='amd64 arm64'; \
;; \
linux) \
ARCHS='386 amd64 arm arm64'; \
ARCHS='amd64 arm64'; \
;; \
windows) \
ARCHS='386 amd64 arm64'; \
ARCHS='amd64 arm64'; \
EXT=".exe"; \
;; \
esac; \
Expand Down
Loading