-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encryption support to sysdump. #295
Conversation
42a980a
to
4ce19f5
Compare
2f37b38
to
af12bb0
Compare
c5b3811
to
5464a16
Compare
5464a16
to
aa635b2
Compare
Adds a '--encrypt' flag (defaulting to false) that encrypts the resulting zip file with either the bundled default public key or the public keys specified via '--encryption-key'. Co-authored-by: Bruno Miguel Custódio <brunomcustodio@gmail.com> Co-authored-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
aa635b2
to
90f5bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to embed the public key instead of asking the users to provide one! LGTM :)
It looks like this PR has gone stale and it would now need a rebase. If you are interested in reviving this, it may be worth syncing with @tklauser / @michi-covalent to agree on the approach, then you would be welcome to reopen a PR to submit this feature again. |
Adds a
--encrypt
flag (defaulting totrue
) that encrypts the resulting zip file with either the bundled public key or the public key specified via--encryption-key
.