Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption support to sysdump. #295

Closed
wants to merge 1 commit into from

Conversation

bmcustodio
Copy link
Contributor

@bmcustodio bmcustodio commented Jun 9, 2021

Adds a --encrypt flag (defaulting to true) that encrypts the resulting zip file with either the bundled public key or the public key specified via --encryption-key.

@bmcustodio bmcustodio requested review from a team as code owners June 9, 2021 13:23
@bmcustodio bmcustodio temporarily deployed to ci June 9, 2021 13:23 Inactive
sysdump/encryption.go Outdated Show resolved Hide resolved
@bmcustodio bmcustodio temporarily deployed to ci June 9, 2021 14:05 Inactive
sysdump/sysdump.go Outdated Show resolved Hide resolved
Adds a '--encrypt' flag (defaulting to false) that encrypts the
resulting zip file with either the bundled default public key or the
public keys specified via '--encryption-key'.

Co-authored-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
Co-authored-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
@bmcustodio bmcustodio temporarily deployed to ci June 9, 2021 15:26 Inactive
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to embed the public key instead of asking the users to provide one! LGTM :)

@bmcustodio bmcustodio marked this pull request as draft July 8, 2021 08:04
@joestringer
Copy link
Member

It looks like this PR has gone stale and it would now need a rebase. If you are interested in reviving this, it may be worth syncing with @tklauser / @michi-covalent to agree on the approach, then you would be welcome to reopen a PR to submit this feature again.

@joestringer joestringer closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants