Fix golang 1.10 build on Ubuntu with snap packages #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `-i` in the "go build" arguments with Golang 1.10 on Ubuntu using
a snap package results in this error:
$ make -C daemon
CHECK contrib/scripts/bindata.sh
GO daemon/cilium-agent
go build runtime/cgo: open /snap/go/2130/pkg/linux_amd64/runtime/cgo.a: read-only file system
According to the upstream issue, this is because it's attempting to rebuild
the core Golang packages on the system, and snap is preventing this via a
read-only file system to ensure consistency for the base Golang version.
The workaround suggested in the following issue is to remove `-i`.
golang/go#24674
Signed-off-by: Joe Stringer <joe@covalent.io>
joestringer
added
pending-review
area/misc
|
test-me-please |
aanm
approved these changes
Jun 22, 2018
|
probably needs backport as will backport go 1.10? |
|
Does this only affect developer builds or also the container image builds? |
tgraf
approved these changes
Jun 22, 2018
|
@tgraf Just developer builds on Ubuntu when using snaps for golang installation (not other methods). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
-iin the "go build" arguments with Golang 1.10 on Ubuntu usinga snap package results in this error:
According to the upstream issue, this is because it's attempting to rebuild
the core Golang packages on the system, and snap is preventing this via a
read-only file system to ensure consistency for the base Golang version.
The workaround suggested in the following issue is to remove
-i.golang/go#24674
For more information, see the Golang 1.10 release notes:
https://golang.org/doc/go1.10#build
This change is