Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile cleanups / improvements #1600

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Makefile cleanups / improvements #1600

merged 2 commits into from
Oct 7, 2024

Commits on Oct 6, 2024

  1. Drop building 32-bit release binaries 

    Depending on the upstream Cilium packages you import, you may
transitively pull in the agent, which does not build on 32-bit
OSes due to the following error, which also breaks the Hubble build:

vendor/github.com/cilium/cilium/pkg/mountinfo/mountinfo_linux.go:56:27: invalid operation: fst.Type == mntType (mismatched types int32 and int64)

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
    @chancez @michi-covalent
    chancez authored and michi-covalent committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    c3f663b View commit details
    Browse the repository at this point in the history

  2. Makefile: Use hubble target to build release binaries 

    Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
    @chancez @michi-covalent
    chancez authored and michi-covalent committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    298cf70 View commit details
    Browse the repository at this point in the history