Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Pin Hubble v0.5.1 in v0.5 branch #249

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

gandro
Copy link
Member

@gandro gandro commented Apr 29, 2020

Reviewer note: This is PR targeting the v0.5 branch.

In the Cilium documentation, we ask users to obtain the Hubble v0.5
chart via the v0.5 branch. Therefore we should make sure that our chart
refers to v0.5 image tags.

Ref: cilium/cilium#11121

In the Cilium documentation, we ask users to obtain the Hubble v0.5
chart via the v0.5 branch. Therefore we should make sure that the chart
refers to v0.5 image tags.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro
Copy link
Member Author

gandro commented Apr 29, 2020

We seem to have a unit test flake in the 0.5 branch:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x100f40b]

goroutine 14 [running]:
github.com/cilium/hubble/pkg/parser/endpoint.ParseEndpointFromModel(0x0, 0x1)
	/home/runner/work/hubble/go/src/github.com/cilium/hubble/pkg/parser/endpoint/endpoint.go:34 +0x4b
github.com/cilium/hubble/pkg/cilium.(*State).consumeEndpointEvents(0xc0003f2180)
	/home/runner/work/hubble/go/src/github.com/cilium/hubble/pkg/cilium/endpoint.go:90 +0x7e9
created by github.com/cilium/hubble/pkg/cilium.TestObserverServer_EndpointAddEvent
	/home/runner/work/hubble/go/src/github.com/cilium/hubble/pkg/cilium/endpoint_test.go:222 +0x990
FAIL	github.com/cilium/hubble/pkg/cilium	0.505s

@gandro gandro merged commit 8adcfe8 into v0.5 Apr 29, 2020
@gandro gandro deleted the pr/gandro/pin-hubble-image-tag-in-v0.5 branch April 29, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants