make: fix git hash variable assignments for old make versions #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antediluvian versions of GNU make, such as the one shipped by default on MacOS (GNU Make 3.81, the last GPLv2 version released back in 2006) do not understand the `!=` operator which executes and assigns the results to a variable. This results in the GIT_BRANCH and GIT_HASH variables not being assigned on MacOS. This commit addresses this issue by using the `$(shell ...)` construct instead. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
|
tested on mac: |
glibsm
approved these changes
Jun 5, 2020
michi-covalent
added
the
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antediluvian versions of GNU make, such as the one shipped by default on
MacOS (GNU Make 3.81, the last GPLv2 version released back in 2006) do
not understand the
!=operator which executes and assigns the resultsto a variable. This results in the GIT_BRANCH and GIT_HASH variables not
being assigned on MacOS. This commit addresses this issue by using the
$(shell ...)construct instead.Signed-off-by: Robin Hahling robin.hahling@gw-computing.net