-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: bump cobra to v1.1.1 #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this won't be enough as our go.mod
still points to gopkg.in/yaml.v2 v2.3.0
(ie the version with the unintended breaking change that cobra v1.1.1 reverted). Please, also downgrade the yaml
to gopkg.in/yaml.v2 v2.2.8
.
Might need to use replace directive to enforce v2.2.8 as well. Thinking about it, I noticed that cilium is using v2.3.0, is there anything to worry about? /cc @rolinh @aanm |
9ca542f
to
78c1b60
Compare
gopkg.in/yaml.v2 version 2.3.0 changes the default line wrapping from 80 characters to none. This potentially breaks Kubernetes and Helm. See spf13/cobra#1259 for discussion. Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
78c1b60
to
1ae702e
Compare
Thanks for the feedback, PR updated to pin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Seems like I have permission in hubble as well, I thought it's only cilium repo :)
cobra 1.1.0 inadvertently included a breaking YAML change affecting
kubectl and helm. See spf13/cobra#1259 for
details.
Signed-off-by: Tom Payne tom@isovalent.com