v0.7: build: ensure that binaries are always statically built #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current make release iterates over supported OS/Arch versions to
cross-compile release binaries. For all platforms that are NOT the same
as the one from which the build is run, CGO is automatically disabled.
This is expected as per the reference documentation[0]:
> The cgo tool is enabled by default for native builds on systems where
> it is expected to work. It is disabled by default when
> cross-compiling.
However, when GOOS and GOARCH are the same as the host doing the build,
it seems that CGO is NOT automatically disabled. As we create release
binaries using an Alpine image, this means that the release binary for
Linux/AMD64 is dynamically linked against the musl libc. Example:
$ file hubble
hubble: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-x86_64.so.1, Go BuildID=VA3fxK4tBsB4Zv8nGvhH/7h_TRfu0LvM0YKIBgvPu/uAObRaQQw0vOXYy0NVTF/6uhxSQlWDiL3MyvZeamO, stripped
This renders the binary unusable on most platforms. To address this,
ensure we always disable CGO.
[0]: https://golang.org/cmd/cgo/#hdr-Go_references_to_C
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
🧰 kind/backport
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rolinh
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
gandro
approved these changes
Oct 20, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #397 to the v0.7 branch.