Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix environment variable names for options with dashes #407

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Oct 21, 2020

See commits for a longer explanation. This PR also updates the long help for the config command.

Environment variable names shall consist solely of uppercase letters,
digits and the underscore character. When using environment variables,
viper shall be instructed to replace '-' in option names by '_' in
corresponding environment variables.

Before this commit, using environment variables for options such as
"tls-allow-insecure" was impossible. It can now be done by using
"HUBBLE_TLS_ALLOW_INSECURE".

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added 🐛 kind/bug This is a bug in the Hubble logic. ⌨️ area/cli Impacts the command line interface of any command in the repository. release-note/bug This PR fixes an issue in a previous release of Hubble. labels Oct 21, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 21, 2020
@rolinh rolinh added the needs-backport/0.7 This PR needs backporting to the v0.7 branch. label Oct 21, 2020
@rolinh rolinh merged commit ea10949 into master Oct 22, 2020
@rolinh rolinh deleted the pr/rolinh/update-config-help branch October 22, 2020 07:55
@rolinh rolinh added backport-pending/0.7 The backport for Hubble 0.7.x for this PR is in progress. backport-done/0.7 The backport for Hubble 0.7.x for this PR is done. and removed needs-backport/0.7 This PR needs backporting to the v0.7 branch. backport-pending/0.7 The backport for Hubble 0.7.x for this PR is in progress. labels Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. backport-done/0.7 The backport for Hubble 0.7.x for this PR is done. 🐛 kind/bug This is a bug in the Hubble logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants