-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/observe: Add node name filter #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
PR is blocked until the release note is set
label
Oct 30, 2020
4 tasks
twpayne
added
release-note/minor
This PR introduces functionality that users may find relevant to operating Hubble.
⌨️ area/cli
Impacts the command line interface of any command in the repository.
labels
Oct 31, 2020
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
PR is blocked until the release note is set
label
Oct 31, 2020
glibsm
reviewed
Nov 3, 2020
twpayne
force-pushed
the
pr/twpayne/node-name-filter
branch
from
November 3, 2020 18:17
732349f
to
a3c910f
Compare
twpayne
force-pushed
the
pr/twpayne/node-name-filter
branch
from
November 20, 2020 12:08
a3c910f
to
752c6aa
Compare
Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/node-name-filter
branch
from
November 20, 2020 12:11
752c6aa
to
6d37d20
Compare
Fixes #266. |
rolinh
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected, brilliant 🎉
$ hubble observe --node-name 'kind-control*' --last 1000 --print-node-name | head
TIMESTAMP NODE SOURCE DESTINATION TYPE VERDICT SUMMARY
Nov 20 13:55:19.001 kind-control-plane 10.244.0.90:46408 10.244.2.63:4240 to-overlay FORWARDED TCP Flags: SYN
Nov 20 13:55:19.720 kind-control-plane 10.244.0.90 10.244.1.236 to-overlay FORWARDED ICMPv4 Redirect(Host)
Nov 20 13:55:19.720 kind-control-plane 10.244.0.90 10.244.1.236 Unsupported protocol for NAT masquerade DROPPED ICMPv4 Redirect(Host)
Nov 20 13:55:20.014 kind-control-plane 10.244.0.90:46408 10.244.2.63:4240 to-overlay FORWARDED TCP Flags: SYN
Nov 20 13:55:20.014 kind-control-plane 10.244.0.90:46408 10.244.2.63:4240 to-overlay FORWARDED TCP Flags: ACK
Nov 20 13:55:20.014 kind-control-plane 10.244.0.90:46408 10.244.2.63:4240 to-overlay FORWARDED TCP Flags: ACK, PSH
Nov 20 13:55:20.014 kind-control-plane 10.244.0.90:46408 10.244.2.63:4240 to-overlay FORWARDED TCP Flags: ACK
Nov 20 13:55:20.015 kind-control-plane 10.244.0.90:49010 10.244.3.37:4240 to-overlay FORWARDED TCP Flags: SYN
Nov 20 13:55:20.015 kind-control-plane 10.244.0.90:49010 10.244.3.37:4240 to-overlay FORWARDED TCP Flags: ACK
gandro
approved these changes
Nov 23, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⌨️ area/cli
Impacts the command line interface of any command in the repository.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR introduces functionality that users may find relevant to operating Hubble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires cilium/cilium#13938 to be merged and Cilium to be updated before this will compile.
Closes #266.