Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/observe: Add node name filter #412

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Oct 30, 2020

Requires cilium/cilium#13938 to be merged and Cilium to be updated before this will compile.

Closes #266.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 30, 2020
@twpayne twpayne added release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. ⌨️ area/cli Impacts the command line interface of any command in the repository. labels Oct 31, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 31, 2020
cmd/observe/observe.go Outdated Show resolved Hide resolved
@twpayne twpayne force-pushed the pr/twpayne/node-name-filter branch from 732349f to a3c910f Compare November 3, 2020 18:17
@twpayne twpayne force-pushed the pr/twpayne/node-name-filter branch from a3c910f to 752c6aa Compare November 20, 2020 12:08
Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne force-pushed the pr/twpayne/node-name-filter branch from 752c6aa to 6d37d20 Compare November 20, 2020 12:11
@twpayne twpayne marked this pull request as ready for review November 20, 2020 12:28
@twpayne twpayne requested review from rolinh and gandro November 20, 2020 12:28
@twpayne
Copy link
Contributor Author

twpayne commented Nov 20, 2020

@rolinh @gandro This is now ready for review.

@twpayne
Copy link
Contributor Author

twpayne commented Nov 20, 2020

Fixes #266.

Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected, brilliant 🎉

$ hubble observe --node-name 'kind-control*' --last 1000 --print-node-name | head
TIMESTAMP             NODE                 SOURCE               DESTINATION          TYPE                                      VERDICT     SUMMARY
Nov 20 13:55:19.001   kind-control-plane   10.244.0.90:46408    10.244.2.63:4240     to-overlay                                FORWARDED   TCP Flags: SYN
Nov 20 13:55:19.720   kind-control-plane   10.244.0.90          10.244.1.236         to-overlay                                FORWARDED   ICMPv4 Redirect(Host)
Nov 20 13:55:19.720   kind-control-plane   10.244.0.90          10.244.1.236         Unsupported protocol for NAT masquerade   DROPPED     ICMPv4 Redirect(Host)
Nov 20 13:55:20.014   kind-control-plane   10.244.0.90:46408    10.244.2.63:4240     to-overlay                                FORWARDED   TCP Flags: SYN
Nov 20 13:55:20.014   kind-control-plane   10.244.0.90:46408    10.244.2.63:4240     to-overlay                                FORWARDED   TCP Flags: ACK
Nov 20 13:55:20.014   kind-control-plane   10.244.0.90:46408    10.244.2.63:4240     to-overlay                                FORWARDED   TCP Flags: ACK, PSH
Nov 20 13:55:20.014   kind-control-plane   10.244.0.90:46408    10.244.2.63:4240     to-overlay                                FORWARDED   TCP Flags: ACK
Nov 20 13:55:20.015   kind-control-plane   10.244.0.90:49010    10.244.3.37:4240     to-overlay                                FORWARDED   TCP Flags: SYN
Nov 20 13:55:20.015   kind-control-plane   10.244.0.90:49010    10.244.3.37:4240     to-overlay                                FORWARDED   TCP Flags: ACK

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 23, 2020
@gandro gandro merged commit 0c6d012 into master Nov 23, 2020
@gandro gandro deleted the pr/twpayne/node-name-filter branch November 23, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter by node names
4 participants