Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version into VERSION file #434

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Move version into VERSION file #434

merged 2 commits into from
Nov 23, 2020

Conversation

glibsm
Copy link
Member

@glibsm glibsm commented Nov 20, 2020

Signed-off-by: Glib Smaga code@gsmaga.com

Signed-off-by: Glib Smaga <code@gsmaga.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Nov 20, 2020
@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 20, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label PR is blocked until the release note is set labels Nov 20, 2020
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that RELEASE.md needs to be updated for the change.

@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 23, 2020
Signed-off-by: Glib Smaga <code@gsmaga.com>
@glibsm
Copy link
Member Author

glibsm commented Nov 23, 2020

I quickly peeked into it initially but didn't see the Makefile part. I updated it, thanks.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 23, 2020
@glibsm glibsm merged commit e5fd470 into master Nov 23, 2020
@glibsm glibsm deleted the pr/glibsm/version branch November 23, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants