ci: do not upload artifacts #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file does more than just run unit tests. Rename it to avoid confusion. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
We do not make any use of these artifacts, hence prune the step that uploads artifacts. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
the
release-note/misc
gandro
reviewed
Feb 10, 2021
| - name: Generate artifacts | ||
| - name: Build | ||
| run: make | ||
| - name: Build release binaries |
There was a problem hiding this comment.
Out of scope for this PR, but I think the original intent here was automating the binary generation. We should see how hard it would be to automatically create a release via GH API for each newly created v* tag.
gandro
approved these changes
Feb 10, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.