Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/observe: print filters in debug mode #502

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Mar 4, 2021

When debugging, it can be really useful to know about the filters that have been generated.

Example:

$ hubble --debug observe --ip 9.9.9.9  > /dev/null
Using config file: /home/user/.config/hubble/config.yaml
Using filters:
=> include: [{"source_ip":["9.9.9.9"]},{"destination_ip":["9.9.9.9"]}]
=> exclude: <nil>

@rolinh rolinh added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels Mar 4, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 4, 2021
cmd/observe/observe.go Outdated Show resolved Hide resolved
When debugging, it can be really useful to know about the filters that
have been generated.

Example:

    $ hubble --debug observe --ip 9.9.9.9  > /dev/null
    Using config file: /home/user/.config/hubble/config.yaml
    Using filters:
    => include: [{"source_ip":["9.9.9.9"]},{"destination_ip":["9.9.9.9"]}]
    => exclude: <nil>

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/observe-debug-filters branch from de4d1fc to 2289b43 Compare March 8, 2021 14:32
@gandro gandro merged commit 63d154c into master Mar 8, 2021
@gandro gandro deleted the pr/rolinh/observe-debug-filters branch March 8, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants