Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: cmd/observe: set default output format to "compact" #536

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Apr 23, 2021

Before this commit, the default output format was set to "compact" when
in follow mode and to "tab" otherwise. Automagically changing default
values based on flags can be off-putting for users. To address this, one
should use a default that is static. As the "tab" output is not
compatible with follow mode, the "compact" output seems like a
reasonable default that works with all flags.

Before this commit, the default output format was set to "compact" when
in follow mode and to "tab" otherwise. Automagically changing default
values based on flags can be off-putting for users. To address this, one
should use a default that is static. As the "tab" output is not
compatible with follow mode, the "compact" output seems like a
reasonable default that works with all flags.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 23, 2021
@rolinh rolinh added the release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. label Apr 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 23, 2021
@michi-covalent michi-covalent merged commit b3109fb into master Apr 27, 2021
@michi-covalent michi-covalent deleted the pr/rolinh/observe-default-output branch April 27, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants