cmd: change "node list" command for "list node" #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently decided to try and uniformize the Hubble CLI subcommands and agreed on a `[verb] [noun]` approach. Given that there haven't been any release of Hubble CLI with the `nodes` subcommand yet, change the `hubble nodes list` command for `hubble list nodes`. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
the
release-note/misc
michi-covalent
approved these changes
May 1, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
One thing to consider is that we don't mirror |
FWIW, I think that's fine. Cilium's CLI uses |
|
This raises a point about uniformity with the new cilium cli. It seems to be mixed currently ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently decided to try and uniformize the Hubble CLI subcommands and
agreed on a
[verb] [noun]approach. Given that there hasn't been anyrelease of Hubble CLI with the
nodessubcommand yet, change thehubble nodes listcommand forhubble list nodes.