Run staticcheck as part of CI #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
reviewed
Feb 19, 2021
In the past there occasionally have been changes in gofmt behavior between Go versions. In order to avoid these, only run gofmt from the latest Go version, i.e. currently Go 1.16. Follow-up for commit 656b9db (".github: use matrix strategy and test with Go 1.15 as well") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/gh-action-staticcheck
branch
from
1181523 to
3ba5d29
Compare
kaworu
approved these changes
Feb 19, 2021
rolinh
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
go installbehavior in Go 1.16 to getstaticcheckwhithout having to add it as a package dependency.Also run
gofmtonly with Go 1.16. In the past there occasionally have been changes ingofmtbehavior between Go versions. In order to avoid these, only rungofmtfrom the latest Go version, i.e. currently Go 1.16.