doc: improve package doc and add a note about unbounded task results #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
area/documentation
tklauser
approved these changes
Nov 2, 2021
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/improve-doc
branch
from
117ad0c to
bfe9bfe
Compare
kaworu
reviewed
Nov 2, 2021
| One caveat is that while the number of concurrently running workers is limited, | ||
| task results are not and they accumulate until they are collected. Therefore, | ||
| if a large number of tasks can be expected, the workerpool should be | ||
| periodically drained (e.g. every 10k tasks). |
There was a problem hiding this comment.
nit
Suggested change
| periodically drained (e.g. every 10k tasks). | |
| periodically drained (e.g. every ten thousand tasks). |
kaworu
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.