Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with empty prefix #226

Merged
merged 1 commit into from
Aug 23, 2018
Merged

fix build with empty prefix #226

merged 1 commit into from
Aug 23, 2018

Conversation

rofl0r
Copy link
Contributor

@rofl0r rofl0r commented Mar 2, 2018

sabotage linux uses an empty prefix, i.e. there's no /usr.
stuff like /include is directly in the root dir.
i run cmake like cmake -DCMAKE_INSTALL_PREFIX=
which usually works everywhere flawlessly, but i got the
following build error here:

CMake Error at src/jsonrpccpp/CMakeLists.txt:228 (get_filename_component):
get_filename_component called with incorrect number of arguments

the cause was omitted quoting of the prefix variable.

sabotage linux uses an empty prefix, i.e. there's no /usr.
stuff like /include is directly in the root dir.
i run cmake like `cmake -DCMAKE_INSTALL_PREFIX=`
which usually works everywhere flawlessly, but i got the
following build error here:
```
CMake Error at src/jsonrpccpp/CMakeLists.txt:228 (get_filename_component):
get_filename_component called with incorrect number of arguments
```
the cause was omitted quoting of the prefix variable.
@rofl0r
Copy link
Contributor Author

rofl0r commented Mar 2, 2018

travis build errors are unrelated:

==> Validating source files with sha1sums...
    argtable2-13.tar.gz ... FAILED
==> ERROR: One or more files did not pass the validity check!

maybe you should get if fixed.

@cinemast cinemast merged commit 04dbe12 into cinemast:master Aug 23, 2018
@cinemast
Copy link
Owner

Thanks!

@rofl0r
Copy link
Contributor Author

rofl0r commented Aug 23, 2018

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants