Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder profile picture #247

Closed
viasux opened this issue Jan 20, 2022 · 6 comments
Closed

Placeholder profile picture #247

viasux opened this issue Jan 20, 2022 · 6 comments
Milestone

Comments

@viasux
Copy link

viasux commented Jan 20, 2022

Is your feature request related to a problem? Please describe.

Currently, when an avatar hasn't loaded yet, it shows up as a cut off "Av"

Describe the solution you'd like

Having a placeholder profile picture would help decrease visual clutter

Additional context

Un-loaded avatars currently look cluttered to me, example:
image

@kfiven
Copy link
Collaborator

kfiven commented Jan 21, 2022

Done in f0c9a45

@kfiven kfiven closed this as completed Jan 21, 2022
@kfiven kfiven added this to the v1.7.0 milestone Jan 21, 2022
@viasux
Copy link
Author

viasux commented Jan 29, 2022

This appears to still be happening in 1.7.0.

image

@viasux
Copy link
Author

viasux commented Jan 29, 2022

This appears to still be happening in 1.7.0.

image

@kfiven (sorry for @, just can't re-open the issue and im unsure if that comment gave you a ping)

@kfiven kfiven reopened this Jan 30, 2022
@kfiven
Copy link
Collaborator

kfiven commented Jan 30, 2022

Could you please test the same on app.cinny.in with a test account?

@viasux
Copy link
Author

viasux commented Jan 30, 2022

yeah, I'll do so in a bit!

@kfiven
Copy link
Collaborator

kfiven commented Jan 30, 2022

This is also specific to firefox based browsers. Firefox show avatar until picture is loaded, if it fails then the broken fallback comes.

So fallback works but firefox does something weird when trying to load avatar.

@ajbura ajbura modified the milestones: v1.7.0, v1.8.0 Feb 5, 2022
ajbura added a commit that referenced this issue Feb 5, 2022
Signed-off-by: ajbura <ajbura@gmail.com>
@kfiven kfiven closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants