Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth - URL Navigation #1603

Merged
merged 70 commits into from
Jan 21, 2024
Merged

Auth - URL Navigation #1603

merged 70 commits into from
Jan 21, 2024

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Dec 20, 2023

Description

This is first part of making Cinny's layout URL responsive. This PR refactor auth logic and add password reset screen and register with token feature.

#26
#167
#234
#1038
#1269
#1285
#1369
#1384
#1426

BRAKING CHANGE: self hosted instances now have to configure url re-writes because we are using in-app react-router. example: /netlify.toml

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Dec 21, 2023

Preview: https://1603--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura changed the title URL Navigation Auth - URL Navigation Jan 21, 2024
@ajbura ajbura marked this pull request as ready for review January 21, 2024 07:42
@ajbura ajbura merged commit 20db27f into dev Jan 21, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants