Upgrade with 2.13 CI #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## To make a commit, type your commit message and press CTRL-ENTER. To cancel ## the commit, close the window. To sign off on the commit, press CTRL-S. ## ## You may also reference or close a GitHub issue with this commit. To do so, ## type `#` followed by the `tab` key. You will be shown a list of issues ## related to the current repo. You may also type `owner/repo#` plus the `tab` ## key to reference an issue in a different GitHub repo. .travis.yml | 1 + build.sbt | 10 +++++----- project/build.properties | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-)
[warn] -Xfuture is deprecated: Not used since 2.13.
zakpatterson
force-pushed
the
upgrade-2.13
branch
from
26b279e
to
e67cfd9
Compare
|
For now this is failing because travis can't download oracle jdk? It seems the default image for travis now is xenial, and it's harder to get jdk8 to work on xenial. This error goes away on selecting jdk11. |
zakpatterson
force-pushed
the
upgrade-2.13
branch
from
a1a353d
to
931f701
Compare
zakpatterson
force-pushed
the
upgrade-2.13
branch
from
931f701
to
4e97a0d
Compare
Merged
|
These commits are included in #44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple remaining issues with this:
To get rid of the JavaConverters deprecation isssue, I had to split code on scala versions: 931f701, there's a PR on the scala collection compat that should fix this: Backport scala.jdk.CollectionConverters to 2.11 / 2.12 scala/scala-collection-compat#217
There are still
.mapValuesdeprecation warningssbt-doctest is still using scalatest 3.0.5, so there are a lot of deprecation warnings on running tests.