-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to fs2 3.0, cats-effect 3.0 #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 from me. |
Pity we can't get rid of diff --git a/src/main/scala/io/circe/fs2/package.scala b/src/main/scala/io/circe/fs2/package.scala
index 5b4ee55..56ff443 100644
--- a/src/main/scala/io/circe/fs2/package.scala
+++ b/src/main/scala/io/circe/fs2/package.scala
@@ -5,6 +5,7 @@ import cats.effect.Sync
import io.circe.jawn.CirceSupportParser
import org.typelevel.jawn.{ AsyncParser, ParseException }
import scala.collection.Seq
+import _root_.fs2.RaiseThrowable
package object fs2 {
private[this] val supportParser: CirceSupportParser = new CirceSupportParser(None, true)
@@ -39,7 +40,7 @@ package object fs2 {
final def byteParser[F[_]: Sync](mode: AsyncParser.Mode): Pipe[F, Byte, Json] = _.chunks.through(byteParserC(mode))
- final def decoder[F[_]: Sync, A](implicit decode: Decoder[A]): Pipe[F, Json, A] =
+ final def decoder[F[_]: RaiseThrowable, A](implicit decode: Decoder[A]): Pipe[F, Json, A] =
_.flatMap { json =>
decode(json.hcursor) match {
case Left(df) => Stream.raiseError(df)
|
@arixmkii can you rebase and we'll merge? |
@BenFradet rebased to latest. |
There is fs2 version 3.0.2 already released and I forgot to add it in the moment of rebase. Should I add it or keep as is? |
3.0.1 is fine, I think |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 7 7
======================================
Misses 7 7
Continue to review full report at Codecov.
|
wohoo! |
Fixes #206
There were no APIs with incompatible signatures (in explicit parts) used, so, I only patched Spec to revive
unsafeRunSync()
.Additionally bumped
sbt
, because 1.4.8 causes issues at least on my machine.