gui/func: Add a 'delete after conversion' button (closes #458) #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constantin1489
changed the title
fix typo
Constantin1489
commented
Mar 2, 2023
kindlecomicconverter/KCC_gui.py
Outdated
| @@ -294,6 +294,10 @@ def run(self): | |||
| options.maximizestrips = True | |||
| if GUI.disableProcessingBox.isChecked(): | |||
| options.noprocessing = True | |||
| if GUI.deleteBox.checkState() == 1: | |||
| options.delete = 2 | |||
There was a problem hiding this comment.
I'm not sure this part. options.delete = 2 and so on.
Constantin1489
changed the title
Constantin1489
changed the title
|
Thanks for your PR. You do not need a tristate in your case and can use instead I'll try to do the modification when I find some time. |
|
@darodi Thank you for code reviewing and merging. This was my first experience committing to open-source. I appreciate collaborating with you. |
darodi
pushed a commit
to darodi/kcc
that referenced
this pull request
Mar 27, 2023
* gui/func: add delete button (closes ciromattia#458) * Update KCC_ui.py fix typo * GUI delete option checkBox --------- Co-authored-by: darodi <4682830+darodi@users.noreply.github.com> (cherry picked from commit 17206dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 'Delete after conversion' button.
I think the button works but in the full scenario, I'm not sure.
I just imitated other button objects like
self.croppingBox.So please check the code before merging.