Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSGI Content-Length and Transfer-Encoding #75

Merged
merged 7 commits into from
Mar 12, 2023
Merged

WSGI Content-Length and Transfer-Encoding #75

merged 7 commits into from
Mar 12, 2023

Conversation

cirospaciari
Copy link
Owner

@cirospaciari cirospaciari commented Jan 7, 2023 •
edited
Loading

this is a WIP for #74

  • Use chunked when Content-Length is absent
  • Use Content-Length and try_end on happy path
  • Close connection if Content-Length is too small
  • add on_writable and on_aborted to send more chunks that failed to send with try_end

PS. This will require new binaries

@cirospaciari cirospaciari added the bug Something isn't working label Jan 7, 2023
@cirospaciari cirospaciari self-assigned this Jan 7, 2023
@cirospaciari cirospaciari linked an issue Jan 7, 2023 that may be closed by this pull request
WSGI, ASGI Content-Length and Transfer-Encoding #74
Open
2 tasks
ckcollab
ckcollab reviewed Jan 10, 2023
View reviewed changes
src/socketify/wsgi.py Outdated Show resolved Hide resolved
@cirospaciari @ckcollab
Update src/socketify/wsgi.py
e9cb790 
Co-authored-by: Eric Carmichael <eric@ckcollab.com>
@cirospaciari
Copy link
Owner Author

cirospaciari commented Jan 10, 2023 •
edited
Loading

@ckcollab thanks to get the type, I think I just typed too fast at this moment lol I think today I will finish this PR

@cirospaciari cirospaciari merged commit 819b1f6 into main Mar 12, 2023
@cirospaciari cirospaciari deleted the fix-wsgi branch July 12, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcollab ckcollab ckcollab left review comments

Assignees

@cirospaciari cirospaciari

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSGI, ASGI Content-Length and Transfer-Encoding
2 participants
@cirospaciari @ckcollab