Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: hash files used in the Dockerfile's ADD and COPY instructions #452

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Parser: hash files used in the Dockerfile's ADD and COPY instructions #452

merged 4 commits into from
Aug 23, 2021

Conversation

edigaryev
Copy link
Contributor

Things that are still need to be implemented:

  • provide proper YAML line/column context to the emitted errors and warnings, so that they'll be attached to the corresponding task's dockerfile: field

Resolves #447.

@edigaryev edigaryev requested a review from fkorotkov August 21, 2021 09:01
@edigaryev edigaryev force-pushed the dockerfile-add-copy branch from 8229feb to 4c1fdc9 Compare August 21, 2021 09:02
fkorotkov
fkorotkov reviewed Aug 21, 2021
View reviewed changes
Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to the line/column reporting.

@edigaryev
Copy link
Contributor Author

LGTM. Looking forward to the line/column reporting.

Implemented in a0d90e7.

@edigaryev edigaryev requested a review from fkorotkov August 23, 2021 13:41
@edigaryev edigaryev enabled auto-merge (squash) August 23, 2021 13:41
@edigaryev edigaryev merged commit ceebbda into master Aug 23, 2021
@edigaryev edigaryev deleted the dockerfile-add-copy branch August 23, 2021 13:52
This was referenced Aug 23, 2021
Merged
Closed
@edigaryev edigaryev mentioned this pull request Sep 10, 2021
Closed
@fkorotkov fkorotkov mentioned this pull request Sep 13, 2021
Closed
@anarazel anarazel mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include COPY and ADD values in the Docker builder cache key
2 participants
@edigaryev @fkorotkov