-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unix tools to path; Add C++ build tools; Drop msys2 #15
Conversation
msys2 causes the installation to hang indefinitely. While --params '/NoUpdate' can be provided to workaround the issue, msys2 seems redundant now that the optional Unix tools that come with Git are added to the PATH environment variable. Especially since MinGW-w64 is already installed separately.
Wow! Thank you, @k0ekk0ek! I tried to fix the build but was not able. Will rebuild VMs that Cirrus is using to have the new images pre-cached on them to speed up startup time. |
Thanks @fkorotkov! |
@fkorotkov, could it be that GCE still has the older image cached?
|
Just rebuilt the base images that runs Windows containers, should be working now! Sorry for the delay. |
I think this PR may have broken my workflow on #16 . |
This seem generally help with all my windows-build issues, except I can't find the MSCC in the image? https://cirrus-ci.com/task/5883284922040320?command=build#L188 Seems there is Roslyn (C#? compiler?) and msbuild.exe, but no cl.exe or vcvars*.bat From reading the package |
This PR:
CIRRUS_SHEL: bash
so that the same shell environment can be used across platforms;visualstudio2019-workload-vctools
to allow users to compile with MSVC;msys2
to avoid indefinite hangs of Docker.visualstudio2019-workload-vctools
is to depend on an older version ofdotnetfx
. The latest version has known problems and causes the Visual Studio installer to fail.msys2
is that it isn't required since the Unix tools that ship with Git are available already andmingw
is installed separately.This should solve #12, #13 and #14. Additionally
diff
becomes available and thus should make #11 obsolete. I did a test build before, but this one should report success imminently.