Mount directories directly into $HOME
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After introducing of cirruslabs/tart#733 we can use different VirtioFS tags for different directories and precisely mount them into exact locations. `/Volumes/My Shared Files/` default path is error-prone since some tools don't like whitespaces in paths. With this change directories will be directly mounted into `$HOME`. Fixes #64
edigaryev
reviewed
Mar 11, 2024
internal/commands/prepare/prepare.go
Outdated
| defer session.Close() | ||
|
|
||
| mountScript := fmt.Sprintf( | ||
| "mount_virtiofs tart.virtiofs.%s /Users/%s/%s\n", |
There was a problem hiding this comment.
mount_virtiofs expects a directory to be already created, so we should probably stuff an mkdir -p && ... here to avoid the job failing.
There was a problem hiding this comment.
Great catch. See 012a73f
edigaryev
reviewed
Mar 11, 2024
internal/commands/prepare/prepare.go
Outdated
| defer session.Close() | ||
|
|
||
| mkdirScript := fmt.Sprintf( | ||
| "mkdir -p /Users/%s/%s", |
There was a problem hiding this comment.
What do you think about abstracting Users/%s/%s into separate variable to avoid mismatches between mkdir and mount invocations?
There was a problem hiding this comment.
SGTM. See 9e2887a
edigaryev
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing of cirruslabs/tart#733 we can use different VirtioFS tags for different directories and precisely mount them into exact locations.
/Volumes/My Shared Files/default path is error-prone since some tools don't like whitespaces in paths. With this change directories will be directly mounted into$HOME.Fixes #64