Stream Tart stdout/stderr output to Packer UI #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a Tart VM may involve long running operations such as downloading an IPSW, or installing the OS. Tart gives us progress during these operations, so let's forward it to the Packer UI, the same way the shell-local provisioner does. If a packer.Ui is not provided, we keep the previous code path that returns the output to the caller, for example used by the TartMachineIP helper.
|
fkorotkov
approved these changes
Mar 8, 2024
fkorotkov
approved these changes
Mar 10, 2024
|
Cheers @fkorotkov ! Do I need to do something to merge this? Should we wait for @edigaryev ? |
|
@edigaryev is coming back from PTO tomorrow so I guess let's wait for him if you don't mind. |
|
No problem from my side. I have some more changes lined up, so the only thing is that it's a bit of a pain to juggle the changes into individual PRs on the GitHub side, but I can manage :D |
edigaryev
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a Tart VM may involve long running operations such as downloading an IPSW, or installing the OS. Tart gives us progress during these operations, so let's forward it to the Packer UI, the same way the shell-local provisioner does.
If a packer.Ui is not provided, we keep the previous code path that returns the output to the caller, for example used by the TartMachineIP helper.