-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unneeded steps #126
Skip unneeded steps #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great optimization! One nit pick from me. Do you mind extracting b.config.CommunicatorConfig.Type != "none"
into a variable like communicatorConfigured
. I think it will cleaner to read the code. What do you think?
Thanks!
Absolutely, will push :) |
56c2d98
to
18f954c
Compare
Pushed update :) |
Doh, missed the second one :D |
Without a communicator we can't provision, and if we don't have boot commands there's not any keys to send to the running VM, so running it is not needed. This allows configuring builders that only create the VM, in preparation for later OS installation and provisioning: source "tart-cli" "create-only" { cpu_count = 4 memory_gb = 8 disk_size_gb = 40 from_ipsw = var.ipsw_file vm_name = "pre-install-vm" communicator = "none" }
There's no need to connect to VNC if we have no boot commands to type.
18f954c
to
3733e71
Compare
Like this? |
Without a communicator we can't provision, and if we don't have
boot commands there's not any keys to send to the running VM, so
running it is not needed.
This allows configuring builders that only create the VM,
in preparation for later OS installation and provisioning:
Also, there's no need to connect to VNC if we have no boot commands
to type.