Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Gmail Policies 9.1, 9.2 and 13.1 #310

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Conversation

jkaufman-mitre
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre commented Jun 7, 2024

🗣 Description

The following changes were made to the Gmail baseline:

  • Removed Gmail Policy 9.2 from the baseline.
  • Made 9.2 Policy Statement a note under Gmail 9.1
  • Re-worded Gmail Policy 13.1 and moved some of the wording to the rationale

💭 Motivation and context

Closes #287.
Closes #288
Closes #298

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

@adhilto adhilto added this to the Coast milestone Jun 7, 2024
jkaufman-mitre and others added 2 commits June 10, 2024 09:54
Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
adhilto and others added 2 commits June 10, 2024 09:42
…0.2.md

Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
…0.2.md

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
@buidav buidav self-requested a review June 20, 2024 19:44
@buidav buidav merged commit ac2f940 into main Jun 20, 2024
2 checks passed
@buidav buidav deleted the gmail-changes-post-0.2 branch June 20, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants