Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy group 5 in Classroom baseline stating that only verified teachers can create classes #325

Merged
merged 14 commits into from
Jul 3, 2024
Merged

Add policy group 5 in Classroom baseline stating that only verified teachers can create classes #325

merged 14 commits into from
Jul 3, 2024

Conversation

jkaufman-mitre
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre commented Jun 21, 2024 •
edited by buidav
Loading

🗣 Description

Add policy group 5 in Classroom policy stating that only verified teachers can create classes.

Fixes #272

💭 Motivation and context

Public Comment

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

adhilto
adhilto requested changes Jun 21, 2024
View reviewed changes
baselines/Gmail Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
drift-rules/GWS Drift Monitoring Rules - Gmail.csv Outdated Show resolved Hide resolved
baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
@adhilto adhilto added this to the Coast milestone Jun 21, 2024
@jkaufman-mitre
Copy link
Collaborator Author

Ready for another review.

adhilto
adhilto reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback! All your changes look good. I have just one final possible suggestion.

baselines/Google Classroom Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
@jkaufman-mitre @adhilto
Update baselines/Google Classroom Minimum Viable Secure Configuration…
46219c7 
… Baseline v0.2.md

Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@adhilto
Copy link
Collaborator

adhilto commented Jun 24, 2024

I just added the needed code changes. I'll approve once you:

  • Modify the policy name in the drift rule so it's the same as the md policy
  • Add the pending TTP mapping

@jkaufman-mitre @adhilto
Update drift-rules/GWS Drift Monitoring Rules - Classroom.csv
7345280 
Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@jkaufman-mitre
Copy link
Collaborator Author

@adhilto I will work on getting the TTP mapping, but the drift rules file already has the correct policy statement.

@jkaufman-mitre
Copy link
Collaborator Author

@adhilto The TTP mappings have been added.

@buidav buidav changed the title Classroom changes 272 2 Add policy group 5 in Classroom policy stating that only verified teachers can create classes. Jul 3, 2024
@buidav buidav changed the title Add policy group 5 in Classroom policy stating that only verified teachers can create classes. Add policy group 5 in Classroom baseline stating that only verified teachers can create classes. Jul 3, 2024
@buidav buidav changed the title Add policy group 5 in Classroom baseline stating that only verified teachers can create classes. Add policy group 5 in Classroom baseline stating that only verified teachers can create classes Jul 3, 2024
@buidav buidav merged commit 29a3dae into main Jul 3, 2024
6 checks passed
@buidav buidav deleted the classroom-changes-272-2 branch July 3, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buidav buidav buidav approved these changes

@adhilto adhilto adhilto approved these changes

@mdueltgen mdueltgen mdueltgen approved these changes

@prodjom prodjom Awaiting requested review from prodjom

Assignees

@jkaufman-mitre jkaufman-mitre

@mdueltgen mdueltgen

Labels
Baseline Revision High
Projects
None yet
Milestone
Coast
Development

Successfully merging this pull request may close these issues.

Google classroom baseline, two additional opinions
4 participants
@jkaufman-mitre @adhilto @buidav @mdueltgen