Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #326 - Set numpy install version #327

Closed
wants to merge 1 commit into from

Conversation

jmahrens
Copy link

Fixes Pandas requirements. Closes #326

@adhilto
Copy link
Collaborator

adhilto commented Jul 5, 2024

@jmahrens Thanks for this submission. Just to keep you in the loop, we're a little backed up right now but we'll be reviewing this soon as part of a larger effort to refresh our dependencies (#321).

@buidav buidav requested a review from amart241 July 19, 2024 01:42
@LaurenBassett
Copy link
Collaborator

I address this a little bit in #333 as well.

@adhilto
Copy link
Collaborator

adhilto commented Aug 12, 2024

I'm having some trouble running this.

Here's what I'm doing:

  1. Fresh clone, git clone git@github.com:jmahrens/ScubaGoggles.git
  2. Create a fresh venv, python -m venv .venv and .\.venv\Scripts\activate
  3. Install dependencies, python -m pip install .
  4. Copy over an existing opa executable and my creds json.
  5. Run scubagoggles, scubagoggles gws --subjectemail ahilton@redacted -b gmail
  6. The following error occurs:
    image

For reference, these are the libraries in my venv:
image

And the version of Python I'm using:
image

Testing performed on Windows.

The only way of fixing this I've found is to upgrade my Pandas version.

  1. pip install --upgrade pandas
  2. Ignore the install error. The install was still successful, but this new version conflicts with the version listed in setup.py.
    image
  3. Run ScubaGoggles again. No error this time.

@LaurenBassett I take it you didn't run into this issue?

@LaurenBassett
Copy link
Collaborator

@LaurenBassett I take it you didn't run into this issue?

I did not. Changing the version worked for me. I'm on MacOS though.

@adhilto adhilto added this to the Coast milestone Aug 20, 2024
@adhilto
Copy link
Collaborator

adhilto commented Aug 29, 2024

@jmahrens Once again, thank you for your contribution. I'm going to go ahead and close this as this is addressed in #356, which does a full refresh of all Python module versions. Do feel free to reach out again if that update doesn't resolve the issue you ran into.

@adhilto adhilto closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy 2.0 release breaks Pandas functionality
4 participants