Changed Security to Secure in Reference to Secure Configuration Baselines #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaufman-mitre
requested review from
LaurenBassett,
buidav,
adhilto and
mdueltgen
buidav
requested changes
Sep 4, 2024
There was a problem hiding this comment.
This change is left over from another pull request.
Remove from this PR.
|
@jkaufman-mitre something weird is going on here. Did you source this branch from the latest main? For one thing these baseline files all have the long file names (e.g., "Common Controls Minimum Viable Secure Configuration Baseline v0.2md" instead of "commoncontrols.md." There are also a lot of merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
In the heading of all baselines, it needs to be "Secure Configuration Baseline" not "Security Configuration Baseline".
It was changed in all baselines, except for Drive_Docs since it was already correct and Common Controls as the change for that baseline was handled in #371.
💭 Motivation and context
Guidance from CISA
Fixes #374
🧪 Testing
There is no testing as it does not affect the code.
✅ Pre-approval checklist
This PR has an informative and human-readable title.
Changes are limited to a single goal - eschew scope creep!
If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
The relevant issues PR resolves are linked preferably via closing keywords.
All relevant type-of-change labels have been added.
I have read and agree to the CONTRIBUTING.md document.
These code changes follow cisagov code standards.
All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
Tests have been added and/or modified to cover the changes in this PR.
All new and existing tests pass.
✅ Pre-merge Checklist
This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
Squash all commits into one PR level commit using the Squash and merge button.
✅ Post-merge Checklist
Delete the branch to clean up.
Close issues resolved by this PR if the closing keywords did not activate.