This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Switch to Alpine Linux for the Docker image #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If possible it is preferable to use Alpine for our Docker images as its design is well-suited for Docker images. Since this is a straight- forward image that does not rely on packages with compiled elements we can safely switch from Debian to Alpine for the OS of the underlying Docker image.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Sep 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request switches the underlying operating system of the base Docker image we use from Debian Buster to Alpine Linux 3.16. Any necessary configuration changes to support this change are also made.
💭 Motivation and context
Since Alpine Linux is designed to be lightweight it is especially suited for use in Docker images when other dependencies allow. Since this is a pretty straightforward Python Docker image that does not have any compiled library reliance (like cryptography) we can migrate to an Alpine Linux based image.
🧪 Testing
Automated tests pass. The lambda invokes successfully with
--helpwhen testing my locally built image.✅ Pre-approval checklist