This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Pull in the latest from cisagov/skeleton-docker
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally as of v3.1.0 of actions/setup-go there is a go-version output value to retrieve the version of Go installed by the Action. This allows us to remove the step to manually retrieve this information from the Go executable.
Go 1.16 is no longer supported as of the release of 1.18 so it makes sense to update to the latest version available.
Go 1.19 was released while this branch was in the wings and it makes sense to bump to the latest Go release.
Update Go installation in the `build.yml` workflow
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 1 to 2. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v1...v2) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…orp/setup-terraform-2 Bump hashicorp/setup-terraform from 1 to 2
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…s/setup-python-4 Bump actions/setup-python from 3 to 4
Add a comment that states that the commented out ignore directives are managed by cisagov/skeleton-generic.
This adds the other versioned Actions that should be managed by cisagov/skeleton-generic to the list of commented out dependencies to ignore.
…nores Update Dependabot ignore directives
GitHub has deprecated the set-output command per: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ This updates the GitHub Actions workflow to use the newly preferred method to set the output for a job's step.
Remove usage of `set-output` from our GitHub Actions workflow
Increase the line length maximum from the default of 80 to 88. This 10% increase mirrors the line length allowed in other linter configurations such as black.
…-length_rules Update the `line-length` configuration for `yamllint`
Per PyCQA/flake8#1290 this hook moved from GitLab to GitHub. The version we use is bumped to the latest tag on GitHub as well.
Update the `flake8` pre-commit hook configuration
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back due to issues with upgrading to v6.
Update pre-commit hooks
This configuration file stores information about the labels expected in this repository.
This adds a workflow to ensure that the repository labels are updated to reflect changes to the label configuration file .github/labels.yml.
Add workflow to manage repository labels
Update the configuration for repository labels to remove the leading `#` from color values. With a `#` leading the values they are seen as invalid by the GitHub API.
There was a missing empty line in the `.yamllint` file between two rule definitions.
Update two configuration files
…rations Update some outdated items in the project
Bumps [actions/github-script](https://github.com/actions/github-script) from 5 to 6. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v5...v6) --- updated-dependencies: - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…/github-script-6 Bump actions/github-script from 5 to 6
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
…script Fix overly eager sed commands
Also add a section to update pip and setuptools via pip.
Improve Dockerfile
mcdonnnj
added
bug
LGTM.com is shutting down 2022-12-16 so we should remove all LGTM-related items to prepare for disabling the LGTM.com integration in the organization.
Remove LGTM from the repository
I accidentally clobbered these changes when I was updating cisagov/skeleton-docker#135 for merge. This restores the changes made during review as well as fixing a missed reference to the CISA_USER argument. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Restore Dockerfile changes from review
Enable the dependabot ignore directive for the github/codeql-action GitHub Action.
Apply changes from the `pyupgrade` pre-commit hook to pass linting.
mcdonnnj
force-pushed
the
improvement/pull_in_skeleton_updates
branch
from
cef2f39 to
36b8726
Compare
jsf9k
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request brings in the latest changes from cisagov/skeleton-docker.
💭 Motivation and context
Keeping things up-to-date is good but this was specifically necessary because the
flake8hook forpre-commit's old GitLab URL started requiring a login to access. This resulted in thelintjob failing because it could not pull in that hook.🧪 Testing
Automated testing passes.
✅ Pre-approval checklist
to reflect the changes in this PR.