Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design Vulnerability details page #2352

Merged

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Oct 24, 2023

🗣 Description

Re-design the current Vulnerability details page. Completes issues: #2306, #2307, #2308, #2309

💭 Motivation and context

Change makes for a better user interface for the Vulnerability details page.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Oct 24, 2023
@ameliav ameliav linked an issue Oct 24, 2023 that may be closed by this pull request
5 tasks
@schmelz21 schmelz21 added Frontend ASM-VDB User Interface Javascript Pull requests that update Javascript code Epic An agile epic is a body of work that can be broken down into specific tasks (called user stories) labels Nov 1, 2023
@ValeriaReveles ValeriaReveles marked this pull request as ready for review November 13, 2023 18:53
@ameliav ameliav marked this pull request as draft December 14, 2023 20:54
@schmelz21
Copy link
Collaborator

schmelz21 commented Feb 9, 2024

@ameliav , upon review please remove the CWE Name reference and move forward with merging the Vuln details page in its current state. We will Issue separate tickets to support the notes section and the CWE name. They both require more detailed planning.

@ameliav ameliav marked this pull request as ready for review February 9, 2024 14:41
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

backend/src/api/cpes.ts Show resolved Hide resolved
frontend/src/types/cve.ts Show resolved Hide resolved
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the TODO comments in the code are a bit disconcerting (e.g. //TODO: change this to something else??)

@Matthew-Grayson
Copy link
Contributor

Some of the TODO comments in the code are a bit disconcerting (e.g. //TODO: change this to something else??)

Understandable. There are just a few things about the new tables that don't match the rest of the code base. The column names for one thing use snake case instead of camel case. This adds confusion to development when displaying detailed information from API responses. I think we should make these changes before the new tables are deployed to production.

I'll create an issue and link it.

…g important info at the the top and keeping arrays and joins at the bottom.
@Matthew-Grayson
Copy link
Contributor

Matthew-Grayson commented Feb 9, 2024

@cduhn17 @rapidray12 TODOs captured here.
#2521
#2522
#2523
#2524

Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One comment, on TODOs moving forward, I believe it will be required in future reviews to reference the Issue number also in the code.

@Matthew-Grayson Matthew-Grayson merged commit 8c7ce5f into master Feb 12, 2024
18 of 19 checks passed
@Matthew-Grayson Matthew-Grayson deleted the 2306-redesign-vuln-details-page-overview-section branch February 12, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic An agile epic is a body of work that can be broken down into specific tasks (called user stories) Frontend ASM-VDB User Interface Javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Vuln Details Page: Overview Section
8 participants