-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Remove Arrows From 2FA Component #2462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as advertised in Firefox, Safari, and Chrome. I also see that this solution is recommended in multiple articles and stackoverflow posts.
My one note is to remove the -moz-appearance
line. The appearance
line alone removes the arrows for Firefox in my local testing.
For anyone else reviewing this PR you can run the following commands to pull from the forked repo.
git remote add hawkishpolicy git@github.com:hawkishpolicy/crossfeed.git
git fetch hawkishpolicy
git checkout hawkishpolicy/Development
@schmelz21 I have a request STRY0010699 requesting when the data consumer is taken into the 2FA page, to position the cursor in the text box ready for data entry. Could that be married with this update? |
@dmfezzareed That's good input and I can start coding a solution. I suggest we do it in a separate PR because this one is tied to a forked version of Crossfeed that I can't edit. Additionally, let me know if issue #2260 captures your intent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗣 Description
The number input field for the 2FA auth adds arrows automatically. This scss formats the input field as a textfield and removes the arrows.
w3schools: https://www.w3schools.com/howto/howto_css_hide_arrow_number.asp
💭 Motivation and context
Closes issue #2261
🧪 Testing
Tested in local environment on Firefox, Chrome, and Safari.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist