Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove Arrows From 2FA Component #2462

Merged
merged 3 commits into from
Feb 5, 2024
Merged

UI: Remove Arrows From 2FA Component #2462

merged 3 commits into from
Feb 5, 2024

Conversation

hawkishpolicy
Copy link
Contributor

@hawkishpolicy hawkishpolicy commented Jan 11, 2024

🗣 Description

The number input field for the 2FA auth adds arrows automatically. This scss formats the input field as a textfield and removes the arrows.

w3schools: https://www.w3schools.com/howto/howto_css_hide_arrow_number.asp

💭 Motivation and context

Closes issue #2261

🧪 Testing

Tested in local environment on Firefox, Chrome, and Safari.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as advertised in Firefox, Safari, and Chrome. I also see that this solution is recommended in multiple articles and stackoverflow posts.

My one note is to remove the -moz-appearance line. The appearance line alone removes the arrows for Firefox in my local testing.

For anyone else reviewing this PR you can run the following commands to pull from the forked repo.

git remote add hawkishpolicy git@github.com:hawkishpolicy/crossfeed.git
git fetch hawkishpolicy
git checkout hawkishpolicy/Development

@dmfezzareed
Copy link

dmfezzareed commented Jan 12, 2024

@schmelz21 I have a request STRY0010699 requesting when the data consumer is taken into the 2FA page, to position the cursor in the text box ready for data entry. Could that be married with this update?

@Matthew-Grayson
Copy link
Contributor

@dmfezzareed That's good input and I can start coding a solution. I suggest we do it in a separate PR because this one is tied to a forked version of Crossfeed that I can't edit. Additionally, let me know if issue #2260 captures your intent.

@Matthew-Grayson Matthew-Grayson added Blocked Something must be completed before this task can proceed.. and removed Blocked Something must be completed before this task can proceed.. labels Jan 18, 2024
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 0cce9c9 into cisagov:master Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants