Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autoFocus of input fields for registration, login, and password reset. #2469

Merged

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Jan 16, 2024

🗣 Description

Add auto focus to first field of components related to sign in, registration, and password reset.
Update placeholder text to improve site accessibility when using a screen reader.
Delete AuthContextOld.tsx, commented out code, and unused imports.

💭 Motivation and context

Closes issue #2260

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Jan 16, 2024 that may be closed by this pull request
@Matthew-Grayson
Copy link
Contributor Author

Once PR #2364 is merged, I will resolve any conflicts and mark this ready for review.

@Matthew-Grayson
Copy link
Contributor Author

I'm testing these changes using a screen reader to rule out potential accessibility issues.

@Matthew-Grayson Matthew-Grayson changed the title Enable autoFocus of input field for 2FA authentication. Enable autoFocus of input fields for registration, login, and password reset. Jan 16, 2024
@Matthew-Grayson Matthew-Grayson added the Blocked Something must be completed before this task can proceed.. label Jan 17, 2024
@Matthew-Grayson Matthew-Grayson self-assigned this Jan 17, 2024
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review February 1, 2024 20:12
@Matthew-Grayson Matthew-Grayson added Frontend ASM-VDB User Interface and removed Blocked Something must be completed before this task can proceed.. labels Feb 1, 2024
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matthew-Grayson Matthew-Grayson merged commit 4c309f2 into master Feb 2, 2024
11 checks passed
@Matthew-Grayson Matthew-Grayson deleted the 2260-focus-input-field-for-login-page-and-2fa-component branch February 2, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend ASM-VDB User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus Input Field for Login Page and 2FA Component
3 participants