Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s3 logic and load html email templates from local asset directory #2509

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

nickviola
Copy link
Contributor

@nickviola nickviola commented Feb 6, 2024

πŸ—£ Description

Removes s3 logic and references locally mapped assets.

πŸ’­ Motivation and context

Asked to remove s3 logic and reference assets locally.

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@nickviola nickviola self-assigned this Feb 6, 2024
backend/src/api/helpers.ts Fixed Show resolved Hide resolved
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola nickviola requested a review from ameliav February 15, 2024 15:02
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple console logs but Nick explained why they are there so LGTM!

@nickviola nickviola merged commit 32888f3 into master Feb 15, 2024
14 of 15 checks passed
@nickviola nickviola deleted the issue-2508/remove-s3-html-email-logic branch February 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants