-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acronym to org insert #2520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add acronym to the organization import export functionality
DJensen94
requested review from
rapidray12,
schmelz21,
cduhn17,
aloftus23,
Matthew-Grayson and
nickviola
as code owners
February 9, 2024 15:54
Update the model to have the acronym be the unique constraint on the table
run linter on backend code
update test to create an org from Global Admin
add acronym to org update test
update test to update an org from a global admin to accept acronyms
add semi colon to acronym definition
Run linter on backend
update that verified duplicate names couldn't be entered to check duplicate acronyms can't be entered
update org update test
remove double equal sign
cduhn17
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Matthew-Grayson
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally; looks great!
rapidray12
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add the acronym to the CSV import file, allowing users to add acronyms to current orgs or when creating an org through the CSV import
💭 Motivation and context
This will allow us to add acronyms in our effort to eventually switch over to using the acronym as our unique constraint
🧪 Testing
Tested locally
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist