Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acronym to org insert #2520

Merged
merged 15 commits into from
Feb 14, 2024
Merged

Add acronym to org insert #2520

merged 15 commits into from
Feb 14, 2024

Conversation

DJensen94
Copy link
Contributor

🗣 Description

Add the acronym to the CSV import file, allowing users to add acronyms to current orgs or when creating an org through the CSV import

💭 Motivation and context

This will allow us to add acronyms in our effort to eventually switch over to using the acronym as our unique constraint

🧪 Testing

Tested locally

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

add acronym to the organization import export  functionality
Update the model to have the acronym be the unique constraint on the table
run linter on backend code
update test to create an org from Global Admin
add acronym to org update test
update test to update an org from a global admin to accept acronyms
add semi colon to acronym definition
Run linter on backend
update that verified duplicate names couldn't be entered to check duplicate acronyms can't be entered
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally; looks great!

@DJensen94 DJensen94 merged commit 4a69c0d into master Feb 14, 2024
14 of 15 checks passed
@DJensen94 DJensen94 deleted the DJ_add-acronym-in-import_WIP branch February 14, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants