-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intelx, Hibp, and Cybersixgill to SQS #2530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloftus23
had a problem deploying
to
production
February 13, 2024 16:38 — with
GitHub Actions
Failure
aloftus23
had a problem deploying
to
production
February 13, 2024 16:42 — with
GitHub Actions
Failure
aloftus23
had a problem deploying
to
production
February 13, 2024 16:58 — with
GitHub Actions
Failure
aloftus23
had a problem deploying
to
production
February 13, 2024 20:11 — with
GitHub Actions
Failure
3 tasks
aloftus23
had a problem deploying
to
production
February 13, 2024 20:18 — with
GitHub Actions
Failure
aloftus23
requested review from
rapidray12,
schmelz21,
cduhn17,
Matthew-Grayson and
nickviola
as code owners
February 13, 2024 20:39
cduhn17
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Matthew-Grayson
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
fixes #2533
Add Intelx, Hibp, and Cybersixgill to SQS.
When adding a new scan you need to update or check these files:
- infrastructure/pe_worker.tf: add task definition and service. *Add any environment variables needed (API KEYS)
- infrastructure/vars.tf: Add queue_url and service_name
- infrastructure/stage.tfvars: same as above
- infrastructure/prod.tfvars: same as above
- infrastructure/worker.tf: add queue url to worker_task_execution_role_policy. *Add any environment variables needed (API KEYS)
- backend/env.yml: Add queue url and service name to environment variables. *Add any environment variables needed (API KEYS)
- dev.env.example: Do the same. *Add any environment variables needed (API KEYS)
- backend/serverless.yml: Create scan specific SQS queues
- backend/src/tasks/scanExecution.ts: Add “else if” in handler and define desired_count. *Add any environment variables needed (API KEYS)
- backend/worker/generate_config.sh: update any credentials needed in dataabse.ini
- backend/worker/pe-worker-entry.sh: Add to elif the command needed to run per org
🧪 Testing
Tested locally for all scan types.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.