Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intelx, Hibp, and Cybersixgill to SQS #2530

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Add Intelx, Hibp, and Cybersixgill to SQS #2530

merged 8 commits into from
Feb 15, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Feb 13, 2024

🗣 Description

fixes #2533

  • Add memory to scanExecution Lambda. Recommended by Trusted Advisor

Add Intelx, Hibp, and Cybersixgill to SQS.

When adding a new scan you need to update or check these files:
- infrastructure/pe_worker.tf: add task definition and service. *Add any environment variables needed (API KEYS)
- infrastructure/vars.tf: Add queue_url and service_name
- infrastructure/stage.tfvars: same as above
- infrastructure/prod.tfvars: same as above
- infrastructure/worker.tf: add queue url to worker_task_execution_role_policy. *Add any environment variables needed (API KEYS)
- backend/env.yml: Add queue url and service name to environment variables. *Add any environment variables needed (API KEYS)
- dev.env.example: Do the same. *Add any environment variables needed (API KEYS)
- backend/serverless.yml: Create scan specific SQS queues
- backend/src/tasks/scanExecution.ts: Add “else if” in handler and define desired_count. *Add any environment variables needed (API KEYS)
- backend/worker/generate_config.sh: update any credentials needed in dataabse.ini
- backend/worker/pe-worker-entry.sh: Add to elif the command needed to run per org

🧪 Testing

Tested locally for all scan types.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@aloftus23 aloftus23 self-assigned this Feb 13, 2024
@aloftus23 aloftus23 added the Backend ASM-VDB Technical Infrastructure and Database label Feb 13, 2024
@aloftus23 aloftus23 linked an issue Feb 13, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aloftus23 aloftus23 merged commit 868839b into master Feb 15, 2024
17 of 18 checks passed
@aloftus23 aloftus23 deleted the AL-SQS-Local branch February 15, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend ASM-VDB Technical Infrastructure and Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memory to the scanExecution lambda POC of AWS SQS
3 participants