Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more memory to Fargate tasks and cleanup logging #2541

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Feb 15, 2024

🗣 Description

This PR:

  • adds more memory to Fargate tasks to match what Crossfeed had before
  • Cleans up logging
  • Make sure the desired count isn't changed on deployment

💭 Motivation and context

Clean up and small adjustments for SQS workflow.

🧪 Testing

Passes all pytests and pre-checks.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holly fruit salad batman. Those are huge increases.

@aloftus23
Copy link
Contributor Author

Holly fruit salad batman. Those are huge increases.

I had them way too low. We can monitor in the ELK after but figured better safe than sorry for now.

Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloftus23 aloftus23 merged commit e58a23e into master Feb 15, 2024
17 of 18 checks passed
@aloftus23 aloftus23 deleted the AL-SQS-Local branch February 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants