Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vulns to be imported without a service #2582

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Conversation

DJensen94
Copy link
Contributor

@DJensen94 DJensen94 commented Feb 28, 2024

Allow vulnerabilities to be added without a service

🗣 Description

If a vuln doesn't have a port associated with it don't attempt to create a service and insert the vuln without the service

💭 Motivation and context

Credential breaches don't link back to a given service, so they were failing to insert.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@DJensen94 DJensen94 marked this pull request as ready for review February 28, 2024 18:04
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DJensen94 DJensen94 merged commit b3bc06c into master Feb 29, 2024
13 checks passed
@DJensen94 DJensen94 deleted the DJ-universal-pull branch February 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants