Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state input to the organization form #2583

Merged
merged 13 commits into from
Mar 4, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Feb 28, 2024

🗣 Description

Update the Create New Organization form by adding State Input and updating the styling.

💭 Motivation and context

Allows for a better user experience, for new organizations to be assigned to a region through the form.

🧪 Testing

Input field called "Organization State" is added to the form.
Styling is updated.

📷 Screenshots (if appropriate)

Old form
image

New form
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav linked an issue Feb 28, 2024 that may be closed by this pull request
@ameliav
Copy link
Contributor Author

ameliav commented Mar 4, 2024

Todos/notes:

  • Ended up also adding the field "acronym" because submission will not go through without this field. May want to consider adding back-end code to auto assign an acronym to each organization.
  • In the organization table, there is a field called stateName and state. The state field is an abbreviated version of stateName. There should be back-end code that populates them both based on the input, as well as the region-id.
  • The tag selection in the form is broken and needs to be fixed. I added a TODO in code.
  • There is still legacy styling in the form and also no form validation that should be added in the future.

@ameliav ameliav marked this pull request as ready for review March 4, 2024 17:19
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matthew-Grayson
Copy link
Contributor

Matthew-Grayson commented Mar 4, 2024

Looks great and allows us to use the UI to create organizations again.
It's not updating the state / country fields in the organization table though. I think we should either fix that in this PR or create a new issue to do so.

EDIT: I updated the create organization endpoint to populate stateName and regionId. This will at least ensure that region admin dashboard will display the correct organizations. There are several fields that still need to be populated and I will create an issue for those.

@cduhn17 cduhn17 merged commit 7da8691 into master Mar 4, 2024
19 checks passed
@cduhn17 cduhn17 deleted the 2573-ux-update-the-create-new-organization-form branch March 4, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Update the Create New Organization form
5 participants