Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PE and CF API keys to env.yml #2594

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add PE and CF API keys to env.yml #2594

merged 1 commit into from
Mar 1, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Mar 1, 2024

🗣 Description

Need to add PE_API_KEY and CF_API_KEY to env.yml so the Lambda and Fargate tasks have access to the variables from the parameter store.

💭 Motivation and context

Failing cveSync and vulnSync scans.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 self-assigned this Mar 1, 2024
@aloftus23 aloftus23 added the Backend ASM-VDB Technical Infrastructure and Database label Mar 1, 2024
@aloftus23 aloftus23 marked this pull request as ready for review March 1, 2024 15:57
@aloftus23 aloftus23 requested a review from DJensen94 March 1, 2024 16:02
Copy link
Contributor

@DJensen94 DJensen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloftus23 aloftus23 merged commit ee53747 into master Mar 1, 2024
15 checks passed
@aloftus23 aloftus23 deleted the AL-add-PE-API-KEY branch March 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend ASM-VDB Technical Infrastructure and Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants