Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish/acet660 #3518

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Spanish/acet660 #3518

merged 12 commits into from
Sep 25, 2023

Conversation

mattrwins
Copy link
Contributor

@mattrwins mattrwins commented Sep 18, 2023

🗣 Description

Spanish toggle for ACET.
For now, database translations work by reading from the included .xlsx files in App_Data, building a dictionary from the file, and overwriting the English data with the Spanish from the dictionary. All the functions to create the dictionaries are in the ACETBusiness.cs file (separate functions because the dictionary types are different for every excel file).

Added Transloco tokens to:

  • Assessment Details page
  • Assessment Information (Contacts) page
  • ACET Filters
  • Maturity Questions (ACET)
  • Some Question Extras (Reviewed) and other tooltips (expands / collapse / filter)

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@randywoods randywoods merged commit 00b34a1 into develop Sep 25, 2023
3 checks passed
@randywoods randywoods deleted the spanish/acet660 branch September 25, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants