Don't export null HYDRO_DATA_ACTIONS records #3534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Don't blindly write a null HYDRO_DATA_ACTIONS record for every ANSWER record. Also on import, don't attempt to import a row that has no values.
This is the cause of all the DBIO exceptions showing up in the NLog table. A null record was being created for every ANSWER record being exported if the assessment is not a Hydro assessment. If the user tries to import that export, it would build an INSERT statement with nothing between the parentheses in the VALUES clause of the statement.
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist