Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question completion message as a pipe #3562

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

randywoods
Copy link
Collaborator

🗣 Description

The question completion message on the landing page is now a pipe. This means it only executes when the language changes. Also added fallback to English for any undefined keys in other languages.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

The question completion message on the landing page is now a pipe.  This means it only executes when the language changes.  Also added fallback to English for any undefined keys in other languages.
@Marcus-Goectau Marcus-Goectau merged commit 28ffb64 into develop Oct 4, 2023
3 checks passed
@Marcus-Goectau Marcus-Goectau deleted the feature/randy-lang branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants