Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: cset-2561 update npm packages #4269

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feature: cset-2561 update npm packages #4269

merged 2 commits into from
Dec 3, 2024

Conversation

itsmostafa
Copy link
Collaborator

@itsmostafa itsmostafa commented Dec 3, 2024 •
edited
Loading

Remove deprecated document-register-element package
Remove unused and vulnerable gallery-editor sub-dependency package
Fix mismatch between angular packages so they all align with version 18

🗣 Description

💭 Motivation and context

🧪 Testing

tested locally

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@itsmostafa itsmostafa marked this pull request as ready for review December 3, 2024 16:36
@itsmostafa itsmostafa self-assigned this Dec 3, 2024
@randywoods randywoods merged commit a693301 into develop Dec 3, 2024
2 of 3 checks passed
@randywoods randywoods deleted the feature/cset-2561 branch December 3, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randywoods randywoods randywoods approved these changes

Assignees

@itsmostafa itsmostafa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsmostafa @randywoods